On Tue, May 12, 2020 at 8:26 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > acpi_gpiochip_request_interrupts() will check for ACPI handle of > the GPIO chip parent device and bail out if there is none defined. > Thus, has_acpi_companion() is effectively repeating above and > is not needed in the individual driver. > > Assigning ->to_irq() unconditionally doesn't change anything, except > an error code, but this we fix as well by propagating it from > platform_get_irq(). > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Patch applied. Yours, Linus Walleij