Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on gpio/for-next] [also build test ERROR on next-20200512] [cannot apply to linus/master v5.7-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/gpio-dwapb-avoid-error-message-for-optional-IRQ/20200513-025227 base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/mfd/intel_quark_i2c_gpio.c: In function 'intel_quark_gpio_setup': >> drivers/mfd/intel_quark_i2c_gpio.c:219:19: error: 'struct dwapb_port_property' has no member named 'has_irq' pdata->properties->has_irq = true; ^~ # https://github.com/0day-ci/linux/commit/f8686f0bb4ff7fdded832484a559f1454a2a51d2 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout f8686f0bb4ff7fdded832484a559f1454a2a51d2 vim +219 drivers/mfd/intel_quark_i2c_gpio.c 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 189 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 190 static int intel_quark_gpio_setup(struct pci_dev *pdev, struct mfd_cell *cell) 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 191 { 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 192 struct dwapb_platform_data *pdata; 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 193 struct resource *res = (struct resource *)cell->resources; 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 194 struct device *dev = &pdev->dev; 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 195 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 196 res[INTEL_QUARK_IORES_MEM].start = 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 197 pci_resource_start(pdev, MFD_GPIO_BAR); 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 198 res[INTEL_QUARK_IORES_MEM].end = 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 199 pci_resource_end(pdev, MFD_GPIO_BAR); 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 200 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 201 pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 202 if (!pdata) 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 203 return -ENOMEM; 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 204 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 205 /* For intel quark x1000, it has only one port: portA */ 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 206 pdata->nports = INTEL_QUARK_GPIO_NPORTS; 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 207 pdata->properties = devm_kcalloc(dev, pdata->nports, 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 208 sizeof(*pdata->properties), 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 209 GFP_KERNEL); 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 210 if (!pdata->properties) 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 211 return -ENOMEM; 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 212 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 213 /* Set the properties for portA */ 4ba8cfa79f44a948 Jiang Qiu 2016-04-28 214 pdata->properties->fwnode = NULL; 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 215 pdata->properties->idx = 0; 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 216 pdata->properties->ngpio = INTEL_QUARK_MFD_NGPIO; 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 217 pdata->properties->gpio_base = INTEL_QUARK_MFD_GPIO_BASE; e6ca26abd37606ba Phil Edworthy 2018-04-26 218 pdata->properties->irq[0] = pdev->irq; e6ca26abd37606ba Phil Edworthy 2018-04-26 @219 pdata->properties->has_irq = true; 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 220 pdata->properties->irq_shared = true; 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 221 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 222 cell->platform_data = pdata; 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 223 cell->pdata_size = sizeof(*pdata); 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 224 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 225 return 0; 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 226 } 60ae5b9f5cdd80c5 Raymond Tan 2015-02-02 227 :::::: The code at line 219 was first introduced by commit :::::: e6ca26abd37606ba4864f20c85d3fe4a2173b93f gpio: dwapb: Add support for 1 interrupt per port A GPIO :::::: TO: Phil Edworthy <phil.edworthy@xxxxxxxxxxx> :::::: CC: Linus Walleij <linus.walleij@xxxxxxxxxx> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- kbuild@xxxxxxxxxxxx To unsubscribe send an email to kbuild-leave@xxxxxxxxxxxx
