Re: [PATCH] pinctrl: ocelot: Add platform dependency

[Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>]

On 07/05/2020 14:27:06+0200, Lars Povlsen wrote:
> 
> Alexandre Belloni writes:
> 
> > Hi,
> >
> > On 07/05/2020 13:40:15+0200, Geert Uytterhoeven wrote:
> >> The Microsemi Ocelot pin controller is only present on Microsemi Ocelot
> >> and Jaguar2 SoCs.  Add a platform dependency to the PINCTRL_OCELOT
> >> config symbol, to avoid asking the user about it when configuring a
> >> kernel without Ocelot or Jaguar2 support.
> >>
> >
> > I have to NAK here because there are upcoming (hopefully this cycle)
> > SoCs using this driver.
> >
> 
> Not only because of that, but also an arbitrary system connecting to
> ocelot by PCI could be using the driver.
> 

Right, and that was why I removed the dependency when adding jaguar2
support I never booted the mips core of jaguar2, I used it using PCIe.

> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> >> ---
> >>  drivers/pinctrl/Kconfig | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> >> index f0ce4ce3e0f52456..bed67c08a0892240 100644
> >> --- a/drivers/pinctrl/Kconfig
> >> +++ b/drivers/pinctrl/Kconfig
> >> @@ -394,8 +394,8 @@ config PINCTRL_RK805
> >>
> >>  config PINCTRL_OCELOT
> >>       bool "Pinctrl driver for the Microsemi Ocelot and Jaguar2 SoCs"
> >> -     depends on OF
> >> -     depends on HAS_IOMEM
> >> +     depends on OF && HAS_IOMEM
> >> +     depends on MSCC_OCELOT || COMPILE_TEST
> >>       select GPIOLIB
> >>       select GPIOLIB_IRQCHIP
> >>       select GENERIC_PINCONF
> >> --
> >> 2.17.1
> >>
> 
> -- 
> Lars Povlsen,
> Microchip

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com