Re: [PATCH] pinctrl: ocelot: Add platform dependency

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Alexandre,

On Thu, May 7, 2020 at 1:46 PM Alexandre Belloni
<alexandre.belloni@xxxxxxxxxxx> wrote:
> On 07/05/2020 13:40:15+0200, Geert Uytterhoeven wrote:
> > The Microsemi Ocelot pin controller is only present on Microsemi Ocelot
> > and Jaguar2 SoCs.  Add a platform dependency to the PINCTRL_OCELOT
> > config symbol, to avoid asking the user about it when configuring a
> > kernel without Ocelot or Jaguar2 support.
>
> I have to NAK here because there are upcoming (hopefully this cycle)
> SoCs using this driver.

So which symbol do I have to extend the dependency with? ;-)

> > --- a/drivers/pinctrl/Kconfig
> > +++ b/drivers/pinctrl/Kconfig
> > @@ -394,8 +394,8 @@ config PINCTRL_RK805
> >
> >  config PINCTRL_OCELOT
> >       bool "Pinctrl driver for the Microsemi Ocelot and Jaguar2 SoCs"
> > -     depends on OF
> > -     depends on HAS_IOMEM
> > +     depends on OF && HAS_IOMEM
> > +     depends on MSCC_OCELOT || COMPILE_TEST
> >       select GPIOLIB
> >       select GPIOLIB_IRQCHIP
> >       select GENERIC_PINCONF

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds