Re: [PATCH] gpio: exar: Fix bad handling for ida_simple_get error path

[Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>]

śr., 29 kwi 2020 o 15:56 Takashi Iwai <tiwai@xxxxxxx> napisał(a):
>
> The commit 7ecced0934e5 ("gpio: exar: add a check for the return value
> of ida_simple_get fails") added a goto jump to the common error
> handler for ida_simple_get() error, but this is wrong in two ways:
> it doesn't set the proper return code and, more badly, it invokes
> ida_simple_remove() with a negative index that shall lead to a kernel
> panic via BUG_ON().
>
> This patch addresses those two issues.
>
> Fixes: 7ecced0934e5 ("gpio: exar: add a check for the return value of ida_simple_get fails")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>

Patch applied for fixes, thanks!

Bart