Re: [PATCH v3 1/3] gpio: pca953x: Rewrite ->get_multiple() function

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Tue, Apr 28, 2020 at 02:13:21PM +0200, Linus Walleij wrote:
> On Tue, Apr 21, 2020 at 5:42 PM Bartosz Golaszewski
> <bgolaszewski@xxxxxxxxxxxx> wrote:
> > wt., 21 kwi 2020 o 15:03 Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxxxxxxxx> napisał(a):
> > > On Mon, Apr 20, 2020 at 08:27:50PM +0300, Andy Shevchenko wrote:

...

> I don't mind trying to put in code to optimize use cases
> when accessing single bytes here either. But I'd like there
> to be explicit comments in the code saying why these
> optimizations are there. Can we do those on top of
> this (hopefully) known working base?

As I pointed out to Paul, the optimization like he proposed is not bad thing
per se, the implementation is. On top of that I suggested to take a look to IRQ
status bits, which presumable will leverage from this optimization as well.

So, After applying this series it would be matter of change one line in the
->get_multiple() to replace read_regs() with optimized version or so along with
IRQ bits changes.

-- 
With Best Regards,
Andy Shevchenko