Re: [PATCH RFC] dt-bindings: pinctrl: sh-pfc: Convert to json-schema

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

On Fri, Apr 17, 2020 at 4:09 PM Geert Uytterhoeven
<geert+renesas@xxxxxxxxx> wrote:
> Convert the Renesas Pin Function Controller (PFC) Device Tree binding
> documentation to json-schema.
>
> Document missing properties.
> Drop deprecated and obsolete #gpio-range-cells property.
> Update the example to match reality.
> Drop consumer examples, as they do not belong here.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> How to describe that pin configuration nodes can have subnodes?
> E.g.
>
>     arch/arm/boot/dts/sh73a0-kzm9g.dt.yaml: pin-controller@e6050000: mmc: Additional properties are not allowed ('cfg', 'mux' were unexpected)
>
> Dropping "additionalProperties: false" from the patternProperties
> section gets rid of these warnings, but of course it would be better if
> the subnodes would be validated, too.

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml

> +patternProperties:
> +  "^.*$":
> +    if:
> +      type: object
> +    then:
> +      allOf:
> +        - $ref: pincfg-node.yaml#
> +        - $ref: pinmux-node.yaml#
> +      description:
> +        Pinctrl node's client devices use subnodes for desired pin
> +        configuration.
> +        Client device subnodes use below standard properties.
> +
> +      properties:
> +        phandle: true
> +        pins: true
> +        groups: true
> +        function: true
> +        bias-disable: true
> +        bias-pull-down: true
> +        bias-pull-up: true
> +        drive-strength:
> +          enum: [ 3, 6, 9, 12, 15, 18, 21, 24 ] # Superset of supported values
> +        power-source:
> +          enum: [ 1800, 3300 ]
> +        gpio-hog: true
> +        gpios: true
> +        output-high: true
> +        output-low: true

The above list lacks the "input" property. Will add.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds