On Sun, Apr 26, 2020 at 12:35:02AM +0530, Syed Nayyar Waris wrote: > This patch replaces all the existing for_each_set_clump8 and related > function calls in the drivers (gpio and thermal) with the equivalent > new generic for_each_set_clump macro. Why are patches [3/6] and [4/6] included in v2 even though William said they should be ignored? Again, replacing for_each_set_clump8() with for_each_set_clump() does not provide any benefit but may impact performance and makes the code more difficult to follow. So once more, please do not change drivers which are known to work fine with 8 bit clumps, specifically gpio-max3191x.c and gpio-74x164.c. Please in the future include a list of the changes you've made in the cover letter, not just in each individual patch. Thanks, Lukas