Re: [PATCH] gpio: mvebu: Fix probing for chips without PWM

[Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>]

pt., 17 kwi 2020 o 11:22 Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> napisał(a):
>
> The PWM iomem resource is optional and its presence indicates whether
> the GPIO chip has a PWM or not, which is why mvebu_pwm_probe() returned
> successfully when the PWM resource was not present. With f51b18d92b66
> the driver switched to devm_platform_ioremap_resource_byname() and
> its error return is propagated to the caller, so now a missing PWM resource
> leads to a probe error in the driver.
>
> To fix this explicitly test for the presence of the PWM resource and
> return successfully when it's not there. Do this check before the check
> for the clock is done (which GPIO chips without a PWM do not have). Also
> move the existing comment why the PWM resource is optional up to the
> actual check.
>
> Fixes: f51b18d92b66 ("gpio: mvebu: use devm_platform_ioremap_resource_byname()")
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>

Patch applied for fixes, thanks!

Bartosz