Re: [PATCH v1 2/2] pinctrl: intel: Move npins closer to pin_base in struct intel_community

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Wed, Apr 22, 2020 at 12:45:26PM +0300, Andy Shevchenko wrote:
> On Wed, Apr 22, 2020 at 11:50:56AM +0300, Mika Westerberg wrote:
> > On Tue, Apr 21, 2020 at 10:00:49PM +0300, Andy Shevchenko wrote:
> > > It's common across the drivers to use the (pin_base, npins) pair to describe
> > > community characteristics. Thus, move them in the struct intel_community
> > > to be closer to each other.
> > > 
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > > ---
> > >  drivers/pinctrl/intel/pinctrl-intel.h | 5 +++--
> > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/pinctrl/intel/pinctrl-intel.h b/drivers/pinctrl/intel/pinctrl-intel.h
> > > index 058bf2b6d9f0e..bd653f2a07382 100644
> > > --- a/drivers/pinctrl/intel/pinctrl-intel.h
> > > +++ b/drivers/pinctrl/intel/pinctrl-intel.h
> > > @@ -94,12 +94,12 @@ enum {
> > >   * @ie_offset: Register offset of GPI_IE from @regs.
> > >   * @features: Additional features supported by the hardware
> > >   * @pin_base: Starting pin of pins in this community
> > > + * @npins: Number of pins in this community
> > >   * @gpp_size: Maximum number of pads in each group, such as GPI_IS, GPI_IE,
> > >   *            PADCFGLOCK, HOSTSW_OWN. Used when @gpps is %NULL.
> > >   * @gpp_num_padown_regs: Number of pad registers each pad group consumes at
> > >   *			 minimum. Use %0 if the number of registers can be
> > >   *			 determined by the size of the group.
> > > - * @npins: Number of pins in this community
> > >   * @gpps: Pad groups if the controller has variable size pad groups
> > >   * @ngpps: Number of pad groups in this community
> > >   * @pad_map: Optional non-linear mapping of the pads
> > > @@ -121,12 +121,13 @@ struct intel_community {
> > >  	unsigned int ie_offset;
> > >  	unsigned int features;
> > >  	unsigned int pin_base;
> > > +	size_t npins;
> > >  	unsigned int gpp_size;
> > >  	unsigned int gpp_num_padown_regs;
> > > -	size_t npins;
> > >  	const struct intel_padgroup *gpps;
> > >  	size_t ngpps;
> > >  	const unsigned int *pad_map;
> > > +
> > 
> > Unrelated whitespace change?
> 
> Not so. I can add justification to commit message.
> 
> > In any case,
> > 
> > Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> 
> Thanks.


Both pushed to my review and testing queue, thanks!

Second one with slightly updated commit message to reflect blank line change.

-- 
With Best Regards,
Andy Shevchenko