Re: [PATCH v3 1/3] gpio: pca953x: Rewrite ->get_multiple() function

[Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>]

Hello,

On Tue, Apr 21, 2020 at 04:03:00PM +0300, Andy Shevchenko wrote:
> On Mon, Apr 20, 2020 at 08:27:50PM +0300, Andy Shevchenko wrote:
> > The commit 96d7c7b3e654 ("gpio: gpio-pca953x, Add get_multiple function")
> > basically did everything wrong from style and code reuse perspective, i.e.
> > - it didn't utilize existing PCA953x internal helpers
> > - it didn't utilize bitmap API
> > - it misses the point that ilog2(), besides that BANK_SFT is useless,
> >   can be used in macros
> > - it has indentation issues.
> > 
> > Rewrite the function completely.
> 
> Bart, Linus, please, consider this series to be applied, because it has Uwe's fixes.
> We may still discuss the approach with ->get_multiple(), though.
> 
> For the record, should some of us volunteer to be a reviewer for this driver.
> It's awful that almost every release we get something either ugly or broken in it.
> Uwe, would you like to be a designated reviewer (I would also support)?

Yeah that would be fine. I'm not sure how long I will have access to the
hardware I fixed the problem on, but I can see what to do when it
happens.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |