Re: [PATCH] pinctrl: actions: fix function group name for i2c0_group

[Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>]

On Sun, Apr 12, 2020 at 11:58:05PM +0200, Andreas Färber wrote:
> Hi,
> 
> Am 12.04.20 um 16:34 schrieb Amit Singh Tomar:
> > After commit 6f87359e8bcaf88381b9c9c038929e0e6872d308("pinctrl: actions: Fix
> > functions groups names for S700 SoC") following error has been observed
> > while booting Linux on Cubieboard7-lite(based on S700 SoC).
> > 
> > [    1.206245] pinctrl-s700 e01b0000.pinctrl: invalid group "i2c0_mfp" for function "i2c0"
> > 
> > This commit fixes it by using correct name for i2c0_group.
> > 
> > Fixes: 6f87359 ("pinctrl: actions: Fix functions groups names for S700 SoC")
> 
> The commit hash should have 12 digits.
> 
> Please also check the white spaces: The subject seems to have too many after
> "actions:", and there's one missing before each parenthesis above.
> 

Amit, you can use something like this

git log -1 --abbrev-commit --pretty=format:"Fixes: %h (\"%s\")%n" <commit-hash>

Thanks,
Mani

> Regards,
> Andreas
> 
> > Signed-off-by: Amit Singh Tomar <amittomer25@xxxxxxxxx>
> > ---
> >   drivers/pinctrl/actions/pinctrl-s700.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/pinctrl/actions/pinctrl-s700.c b/drivers/pinctrl/actions/pinctrl-s700.c
> > index 47a4ccd..f579a65 100644
> > --- a/drivers/pinctrl/actions/pinctrl-s700.c
> > +++ b/drivers/pinctrl/actions/pinctrl-s700.c
> > @@ -1435,7 +1435,7 @@ static const char * const sd2_groups[] = {
> >   static const char * const i2c0_groups[] = {
> >   	"uart0_rx_mfp",
> >   	"uart0_tx_mfp",
> > -	"i2c0_mfp_mfp",
> > +	"i2c0_mfp",
> >   };
> >   static const char * const i2c1_groups[] = {
> > 
> 
> 
> -- 
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer
> HRB 36809 (AG Nürnberg)