Light can you look into this warning? I think the shadowing is fine, but can we just make the other pullup local to where it is used as well so we get rid of this? Yours, Linus Walleij On Sat, Mar 28, 2020 at 8:42 AM kbuild test robot <lkp@xxxxxxxxx> wrote: > > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel > branch HEAD: 13bec8d49bdf10aab4e1570ef42417f6bfbb6126 pinctrl: qcom: use scm_call to route GPIO irq to Apps > > Regressions in current branch: > > bool pullup; > drivers/pinctrl/mediatek/pinctrl-paris.c:167:9: note: Shadow variable > drivers/pinctrl/mediatek/pinctrl-paris.c:167:9: warning: Local variable 'pullup' shadows outer variable [shadowVariable] > drivers/pinctrl/mediatek/pinctrl-paris.c:81:6: note: Shadowed declaration > int pullup, err, reg, ret = 1; > > Error ids grouped by kconfigs: > > recent_errors > `-- x86_64-allyesconfig > |-- bool-pullup > |-- drivers-pinctrl-mediatek-pinctrl-paris.c:note:Shadow-variable > |-- drivers-pinctrl-mediatek-pinctrl-paris.c:note:Shadowed-declaration > |-- drivers-pinctrl-mediatek-pinctrl-paris.c:warning:Local-variable-pullup-shadows-outer-variable-shadowVariable > `-- int-pullup-err-reg-ret > > elapsed time: 482m > > configs tested: 164 > configs skipped: 0 > > arm allmodconfig > arm allnoconfig > arm allyesconfig > arm64 allmodconfig > arm64 allnoconfig > arm64 allyesconfig > arm at91_dt_defconfig > arm efm32_defconfig > arm exynos_defconfig > arm multi_v5_defconfig > arm multi_v7_defconfig > arm shmobile_defconfig > arm sunxi_defconfig > arm64 defconfig > sparc allyesconfig > mips allnoconfig > nds32 defconfig > sh rsk7269_defconfig > s390 zfcpdump_defconfig > sparc64 allyesconfig > ia64 allyesconfig > ia64 allmodconfig > sparc defconfig > i386 allnoconfig > i386 allyesconfig > i386 alldefconfig > i386 defconfig > ia64 defconfig > ia64 allnoconfig > ia64 alldefconfig > xtensa iss_defconfig > xtensa common_defconfig > openrisc simple_smp_defconfig > openrisc or1ksim_defconfig > nios2 3c120_defconfig > nios2 10m50_defconfig > c6x evmc6678_defconfig > c6x allyesconfig > nds32 allnoconfig > csky defconfig > alpha defconfig > h8300 h8s-sim_defconfig > h8300 edosk2674_defconfig > m68k m5475evb_defconfig > m68k allmodconfig > h8300 h8300h-sim_defconfig > m68k multi_defconfig > m68k sun3_defconfig > arc defconfig > arc allyesconfig > microblaze mmu_defconfig > microblaze nommu_defconfig > powerpc allnoconfig > powerpc defconfig > powerpc ppc64_defconfig > powerpc rhel-kconfig > mips 32r2_defconfig > mips 64r6el_defconfig > mips allmodconfig > mips allyesconfig > mips fuloong2e_defconfig > mips malta_kvm_defconfig > parisc allnoconfig > parisc generic-64bit_defconfig > parisc generic-32bit_defconfig > parisc allyesconfig > x86_64 randconfig-a001-20200327 > x86_64 randconfig-a002-20200327 > x86_64 randconfig-a003-20200327 > i386 randconfig-a001-20200327 > i386 randconfig-a002-20200327 > i386 randconfig-a003-20200327 > mips randconfig-a001-20200327 > nds32 randconfig-a001-20200327 > m68k randconfig-a001-20200327 > parisc randconfig-a001-20200327 > alpha randconfig-a001-20200327 > riscv randconfig-a001-20200327 > c6x randconfig-a001-20200327 > h8300 randconfig-a001-20200327 > microblaze randconfig-a001-20200327 > nios2 randconfig-a001-20200327 > sparc64 randconfig-a001-20200327 > csky randconfig-a001-20200327 > openrisc randconfig-a001-20200327 > s390 randconfig-a001-20200327 > sh randconfig-a001-20200327 > xtensa randconfig-a001-20200327 > x86_64 randconfig-b001-20200327 > x86_64 randconfig-b002-20200327 > x86_64 randconfig-b003-20200327 > i386 randconfig-b001-20200327 > i386 randconfig-b002-20200327 > i386 randconfig-b003-20200327 > x86_64 randconfig-c001-20200327 > x86_64 randconfig-c002-20200327 > x86_64 randconfig-c003-20200327 > i386 randconfig-c001-20200327 > i386 randconfig-c002-20200327 > i386 randconfig-c003-20200327 > x86_64 randconfig-d001-20200327 > x86_64 randconfig-d002-20200327 > x86_64 randconfig-d003-20200327 > i386 randconfig-d001-20200327 > i386 randconfig-d002-20200327 > i386 randconfig-d003-20200327 > x86_64 randconfig-e001-20200327 > x86_64 randconfig-e002-20200327 > x86_64 randconfig-e003-20200327 > i386 randconfig-e001-20200327 > i386 randconfig-e002-20200327 > i386 randconfig-e003-20200327 > x86_64 randconfig-f001-20200327 > x86_64 randconfig-f002-20200327 > x86_64 randconfig-f003-20200327 > i386 randconfig-f001-20200327 > i386 randconfig-f002-20200327 > i386 randconfig-f003-20200327 > x86_64 randconfig-g001-20200327 > x86_64 randconfig-g002-20200327 > x86_64 randconfig-g003-20200327 > i386 randconfig-g001-20200327 > i386 randconfig-g002-20200327 > i386 randconfig-g003-20200327 > x86_64 randconfig-h001-20200327 > x86_64 randconfig-h002-20200327 > x86_64 randconfig-h003-20200327 > i386 randconfig-h001-20200327 > i386 randconfig-h002-20200327 > i386 randconfig-h003-20200327 > arm randconfig-a001-20200327 > ia64 randconfig-a001-20200327 > sparc randconfig-a001-20200327 > arc randconfig-a001-20200327 > arm64 randconfig-a001-20200327 > powerpc randconfig-a001-20200327 > riscv allmodconfig > riscv allnoconfig > riscv allyesconfig > riscv defconfig > riscv nommu_virt_defconfig > riscv rv32_defconfig > s390 alldefconfig > s390 allmodconfig > s390 allnoconfig > s390 allyesconfig > s390 debug_defconfig > s390 defconfig > sh allmodconfig > sh sh7785lcr_32bit_defconfig > sh allnoconfig > sh titan_defconfig > sparc64 allmodconfig > sparc64 allnoconfig > sparc64 defconfig > um x86_64_defconfig > um i386_defconfig > um defconfig > x86_64 rhel-7.6 > x86_64 rhel > x86_64 rhel-7.2-clear > x86_64 lkp > x86_64 fedora-25 > x86_64 kexec > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx