Re: [PATCH v1 2/2] [RFC] gpio: pca953x: drop unused parameters of pca953x_recalc_addr()

[Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>]

On Fri, Mar 27, 2020 at 11:06:43PM +0100, H. Nikolaus Schaller wrote:
> 
> > Am 27.03.2020 um 18:22 schrieb Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>:
> > 
> > After the previous patch the two last parameters of
> > pca953x_recalc_addr() are unused and so can be dropped.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > ---
> > drivers/gpio/gpio-pca953x.c | 31 +++++++++++--------------------
> > 1 file changed, 11 insertions(+), 20 deletions(-)
> > 
> > diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> > index 8168558299c2..f4943cad5d0e 100644
> > --- a/drivers/gpio/gpio-pca953x.c
> > +++ b/drivers/gpio/gpio-pca953x.c
> > @@ -325,8 +325,7 @@ static const struct regmap_config pca953x_ai_i2c_regmap = {
> > 	.max_register = 0x7f,
> > };
> > 
> > -static u8 pca953x_recalc_addr(struct pca953x_chip *chip, int reg, int off,
> > -			      bool write, bool addrinc)
> > +static u8 pca953x_recalc_addr(struct pca953x_chip *chip, int reg, int off)
> > {
> > 	int bank_shift = pca953x_bank_shift(chip);
> > 	int addr = (reg & PCAL_GPIO_MASK) << bank_shift;
> > @@ -338,7 +337,7 @@ static u8 pca953x_recalc_addr(struct pca953x_chip *chip, int reg, int off,
> > 
> > static int pca953x_write_regs(struct pca953x_chip *chip, int reg, unsigned long *val)
> > {
> > -	u8 regaddr = pca953x_recalc_addr(chip, reg, 0, true, true);
> > +	u8 regaddr = pca953x_recalc_addr(chip, reg, 0;
> 
> here is some ")" missing.
> 
> After fix&compile it still works for the pcal6524 of the OMAP5/Pyra
> (LPAE build).

Argh, it seems I didn't try to recompile after rebasing :-|

I'm still waiting for more feedback and then will send out a v2.

Thanks for your test,
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |