Re: [PATCH] tools: gpio: Fix out-of-tree build regression

[Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>]

śr., 25 mar 2020 o 11:33 Anssi Hannula <anssi.hannula@xxxxxxxxxx> napisał(a):
>
> Commit 0161a94e2d1c7 ("tools: gpio: Correctly add make dependencies for
> gpio_utils") added a make rule for gpio-utils-in.o but used $(output)
> instead of the correct $(OUTPUT) for the output directory, breaking
> out-of-tree build (O=xx) with the following error:
>
>   No rule to make target 'out/tools/gpio/gpio-utils-in.o', needed by 'out/tools/gpio/lsgpio-in.o'.  Stop.
>
> Fix that.
>
> Fixes: 0161a94e2d1c ("tools: gpio: Correctly add make dependencies for gpio_utils")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Cc: Laura Abbott <labbott@xxxxxxxxxx>
> Signed-off-by: Anssi Hannula <anssi.hannula@xxxxxxxxxx>
> ---
>
> The 0161a94e2d1c was also applied to stable releases, which is where I
> got hit by the issue.
>
>  tools/gpio/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/gpio/Makefile b/tools/gpio/Makefile
> index 842287e42c83..440434027557 100644
> --- a/tools/gpio/Makefile
> +++ b/tools/gpio/Makefile
> @@ -35,7 +35,7 @@ $(OUTPUT)include/linux/gpio.h: ../../include/uapi/linux/gpio.h
>
>  prepare: $(OUTPUT)include/linux/gpio.h
>
> -GPIO_UTILS_IN := $(output)gpio-utils-in.o
> +GPIO_UTILS_IN := $(OUTPUT)gpio-utils-in.o
>  $(GPIO_UTILS_IN): prepare FORCE
>         $(Q)$(MAKE) $(build)=gpio-utils
>
> --
> 2.21.1
>

Reviewed-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>