On Thu, Mar 12, 2020 at 02:58:33PM +0100, Linus Walleij wrote: > On Fri, Mar 6, 2020 at 2:25 PM <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> wrote: > > > From: Serge Semin <fancer.lancer@xxxxxxxxx> > > > > There is no need in any fixes to have the Baikal-T1 SoC DW GPIO controllers > > supported by the kernel DW APB GPIO driver. It works for them just fine with > > no modifications. But still there is a room for optimizations there. > > > > First of all as it tends to be traditional for all Baikal-T1 SoC related > > patchset we replaced the legacy plain text-based dt-binding file with > > yaml-based one. Baikal-T1 DW GPIO port A supports a debounce functionality, > > but in order to use it the corresponding reference clock must be enabled. > > We added support of that clock in the driver and made sure the dt-bindings > > had its declaration. In addition seeing both APB and debounce reference > > clocks are optional, we replaced the standard devm_clk_get() usage with > > the function of optional clocks acquisition. > > > > This patchset is rebased and tested on the mainline Linux kernel 5.6-rc4: > > commit 98d54f81e36b ("Linux 5.6-rc4"). > > > > Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Alexey Malahov <Alexey.Malahov@xxxxxxxxxxxxxxxxxxxx> > > Cc: Maxim Kaurkin <Maxim.Kaurkin@xxxxxxxxxxxxxxxxxxxx> > > Cc: Pavel Parkhomenko <Pavel.Parkhomenko@xxxxxxxxxxxxxxxxxxxx> > > Cc: Ramil Zaripov <Ramil.Zaripov@xxxxxxxxxxxxxxxxxxxx> > > Cc: Ekaterina Skachko <Ekaterina.Skachko@xxxxxxxxxxxxxxxxxxxx> > > Cc: Vadim Vlasov <V.Vlasov@xxxxxxxxxxxxxxxxxxxx> > > Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> > > Cc: Paul Burton <paulburton@xxxxxxxxxx> > > Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx> > > Cc: Hoan Tran <hoan@xxxxxxxxxxxxxxxxxxxxxx> > > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > > Cc: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > > Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > > Cc: Mark Rutland <mark.rutland@xxxxxxx> > > Cc: linux-gpio@xxxxxxxxxxxxxxx > > Cc: devicetree@xxxxxxxxxxxxxxx > > Cc: linux-kernel@xxxxxxxxxxxxxxx > > I like these patches, once Rob is happy with the bindings I'll be > happy to merge them. I haven't heard from Hoan Tran in a while, > so if we don't hear from him this time either I would suggest you > also add yourself as maintainer for this driver, if you don't mind. > > Thanks, > Linus Walleij Hello Linus, Thanks for positive response. I'll resend the patchset soon in the email-threaded form together with two extra patches, which will add me to the MAINTAINERS list and to the dt-schema of the driver. If Hoan Tran will show up before you merge them, just drop these two new patches. Regards, -Sergey