Re: [RFC 1/8] dt-bindings: video: Add jz4780-lcd binding

[Rob Herring <robh@xxxxxxxxxx>]

On Wed, Feb 26, 2020 at 08:12:53PM +0100, H. Nikolaus Schaller wrote:
> From: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@xxxxxxxxxx>
> 
> Add DT bindings for the LCD controller on the jz4780 SoC
> 
> Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@xxxxxxxxxx>
> ---
>  .../bindings/display/ingenic-jz4780-lcd.txt   | 39 +++++++++++++++++++
>  1 file changed, 39 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/ingenic-jz4780-lcd.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/ingenic-jz4780-lcd.txt b/Documentation/devicetree/bindings/display/ingenic-jz4780-lcd.txt
> new file mode 100644
> index 000000000000..8512ce3f93df
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/ingenic-jz4780-lcd.txt
> @@ -0,0 +1,39 @@
> +Bindings for Ingenic JZ4780 LCD Controller
> +
> +LCD Controller is the Display Controller for the Ingenic JZ4780 SoC
> +
> +Required properties:
> +- compatible: should be "ingenic,jz4780-lcd"
> +- reg: Should contain the address & size of the LCD controller registers.
> +- interrupts: Should specify the interrupt provided by parent.
> +- clocks: Should contain two clock specifiers for the JZ4780_CLK_TVE JZ4780_CLK_LCD0PIXCLK.
> +- clock-names : Must be "lcd_clk", "lcd_pixclk";
> +- port: A port node with endpoint definitions as defined in
> +  Documentation/devicetree/bindings/media/video-interfaces.txt.
> +
> +Optional properties:
> +- interrupt-parent: phandle to parent interrupt controller

Drop this. 'interrupt-parent' is always valid and could be in a parent 
node.

> +
> +Example:
> +
> +lcd: jz4780-lcdk@0x13050000 {

Drop the '0x'.

> +	compatible = "ingenic,jz4780-lcd";
> +	reg = <0x13050000 0x1800>;
> +
> +	clocks = <&cgu JZ4780_CLK_TVE>, <&cgu JZ4780_CLK_LCD0PIXCLK>;
> +	clock-names = "lcd_clk", "lcd_pixclk";
> +
> +	interrupt-parent = <&intc>;
> +	interrupts = <31>;
> +
> +	jz4780_lcd_out: port {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			jz4780_out_hdmi: endpoint@0 {
> +				reg = <0>;

Don't need an address as there's only 1 endpoint.

> +				remote-endpoint = <&hdmi_in_lcd>;
> +			};
> +		};
> +
> +};
> -- 
> 2.23.0
>