There are at least 3 variants of the HP x2 10 models: Bay Trail SoC + AXP288 PMIC Cherry Trail SoC + AXP288 PMIC Cherry Trail SoC + TI PMIC Like on the Bay Trail + AXP288 PMIC model, we also need to ignore wakeups for the GPIO which is (ab)used for embedded-controller events on the Cherry Trail + AXP288 PMIC model. Fixes: aa23ca3d98f7 ("gpiolib: acpi: Add honor_wakeup module-option + quirk mech Reported-and-tested-by: Marc Lehmann <schmorp@xxxxxxxxxx> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> --- drivers/gpio/gpiolib-acpi.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c index 83103efa5862..46b2d74c610c 100644 --- a/drivers/gpio/gpiolib-acpi.c +++ b/drivers/gpio/gpiolib-acpi.c @@ -1400,6 +1400,21 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] = { }, .driver_data = (void *)QUIRK_IGNORE_WAKE(0x1c), }, + { + /* + * HP X2 10 models with Cherry Trail SoC + AXP288 PMIC use an + * external embedded-controller connected via I2C + an ACPI + * GPIO event handler for pin 0x00, causing spurious wakeups. + * Unlike the Cherry Trail + TI PMIC models, we do want to + * honor the ACPI wake flag on the other GPIOs. + */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "HP"), + DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion x2 Detachable"), + DMI_MATCH(DMI_BOARD_NAME, "813E"), + }, + .driver_data = (void *)QUIRK_IGNORE_WAKE(0x00), + }, {} /* Terminating entry */ }; -- 2.25.1