Re: [PATCH] gpio: bd71828: Remove unneeded defines for GPIO_LINE_DIRECTION_IN/OUT

[Axel Lin <axel.lin@xxxxxxxxxx>]

Vaittinen, Matti <Matti.Vaittinen@xxxxxxxxxxxxxxxxx> 於 2020年1月29日 週三 下午11:06寫道：
>
>
> On Wed, 2020-01-29 at 20:30 +0800, Axel Lin wrote:
> > They are defined in gpio/driver.h now.
> >
> > Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
> > ---
> >  drivers/gpio/gpio-bd71828.c | 10 ----------
> >  1 file changed, 10 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-bd71828.c b/drivers/gpio/gpio-
> > bd71828.c
> > index 04aade9e0a4d..3dbbc638e9a9 100644
> > --- a/drivers/gpio/gpio-bd71828.c
> > +++ b/drivers/gpio/gpio-bd71828.c
> > @@ -10,16 +10,6 @@
> >  #define GPIO_OUT_REG(off) (BD71828_REG_GPIO_CTRL1 + (off))
> >  #define HALL_GPIO_OFFSET 3
> >
> > -/*
> > - * These defines can be removed when
> > - * "gpio: Add definition for GPIO direction"
> > - * (9208b1e77d6e8e9776f34f46ef4079ecac9c3c25 in GPIO tree) gets
> > merged,
> > - */
> > -#ifndef GPIO_LINE_DIRECTION_IN
> > -     #define GPIO_LINE_DIRECTION_IN 1
> > -     #define GPIO_LINE_DIRECTION_OUT 0
> > -#endif
> >
>
> Thanks once again for doing the cleanup! :)
Hi Matti,
Can you reply with your Ack?
It would be easier for maintainers to pick up the patch with Ack.

Thanks,
Axel