Re: [RFC PATCH 0/4] pinctrl: bcm2835: Add support for all BCM2711 GPIOs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2020-01-27 at 19:15 +0100, Stefan Wahren wrote:
> The BCM2711 supports 58 GPIOs [1] by using the existing BCM2835 GPIO registers
> completely. So there is no need to change the binding.
> 
> Patch 1 and 2 prepare the pinctrl driver to be extended to 58 GPIOs in Patch
> 3.
> I didn't want to squash them in order to make review as easy as possible.
> The final patch 4 assigns all SoC GPIOs a label as we already did for
> the older Raspberry Pi boards.
> 
> [1] - https://github.com/raspberrypi/linux/issues/3101#issuecomment-573092294
> 
> Stefan Wahren (4):
>   pinctrl: bcm2835: Drop unused define
>   pinctrl: bcm2835: Refactor platform data
>   pinctrl: bcm2835: Add support for all GPIOs on BCM2711
>   ARM: dts: bcm2711-rpi-4-b: Add SoC GPIO labels
> 
>  arch/arm/boot/dts/bcm2711-rpi-4-b.dts |  74 ++++++++++++++++++++++++
>  drivers/pinctrl/bcm/pinctrl-bcm2835.c | 106 ++++++++++++++++++++++++++-------
> -
>  2 files changed, 156 insertions(+), 24 deletions(-)

Overall this looks good to me (modulo the small comments). I also gave it a go
on RPi4 and RPi3b without issues.

Regards,
Nicolas

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux