On Wed, Jan 01, 2020 at 12:41:20PM -0800, Boyan Ding wrote: > Commit 179e5a6114cc ("pinctrl: intel: Remove default Interrupt Status > offset") removes default interrupt status offset of GPIO controllers, > with previous commits explicitly providing the previously default > offsets. However, the is_offset value in SPTH_COMMUNITY is missing, > preventing related irq from being properly detected and handled. > Pushed to my review and testing queue, thanks! > Fixes: f702e0b93cdb ("pinctrl: sunrisepoint: Provide Interrupt Status register offset") > Link: https://bugzilla.kernel.org/show_bug.cgi?id=205745 > Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Boyan Ding <boyan.j.ding@xxxxxxxxx> > --- > drivers/pinctrl/intel/pinctrl-sunrisepoint.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pinctrl/intel/pinctrl-sunrisepoint.c b/drivers/pinctrl/intel/pinctrl-sunrisepoint.c > index 44d7f50bbc82..d936e7aa74c4 100644 > --- a/drivers/pinctrl/intel/pinctrl-sunrisepoint.c > +++ b/drivers/pinctrl/intel/pinctrl-sunrisepoint.c > @@ -49,6 +49,7 @@ > .padown_offset = SPT_PAD_OWN, \ > .padcfglock_offset = SPT_PADCFGLOCK, \ > .hostown_offset = SPT_HOSTSW_OWN, \ > + .is_offset = SPT_GPI_IS, \ > .ie_offset = SPT_GPI_IE, \ > .pin_base = (s), \ > .npins = ((e) - (s) + 1), \ > -- > 2.24.0 > -- With Best Regards, Andy Shevchenko