Re: [PATCH v2] pinctrl: baytrail: Remove WARN when setting direct-irq pin to output

[Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>]

On Wed, Dec 25, 2019 at 02:28:12PM +0100, Hans de Goede wrote:
> Suspending Goodix touchscreens requires changing the interrupt pin to
> output before sending them a power-down command. Followed by wiggling
> the interrupt pin to wake the device up, after which it is put back
> in input mode.
> 
> On Cherry Trail device the interrupt pin is listed as a GpioInt ACPI
> resource so we can do this without problems as long as we release the
> irq before changing the pin to output mode.
> 
> On Bay Trail devices with a Goodix touchscreen direct-irq mode is used
> in combination with listing the pin as a normal GpioIo resource. This
> works fine, but this triggers the WARN in byt_gpio_set_direction-s output
> path because direct-irq support is enabled on the pin.
> 
> This commit removes the WARN call, fixing a bunch of WARN splats in
> dmesg on each suspend/resume cycle.

But this is still something we don't expect to do normally, right? How
about changing this to dev_warn() or dev_info() so it is still visible
in dmesg and possibly helps future debugging.