Re: [PATCH v2 1/1] pinctrl: iproc: Set irq handler based on trig type

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Sun, Dec 15, 2019 at 10:05 PM Hamish Martin
<hamish.martin@xxxxxxxxxxxxxxxxxxx> wrote:

> Rather than always using handle_simple_irq() as the gpio_irq_chip
> handler, set a more appropriate handler based on the IRQ trigger type
> requested.
> This is important for level triggered interrupts which need to be
> masked during handling.
>
> Signed-off-by: Hamish Martin <hamish.martin@xxxxxxxxxxxxxxxxxxx>
> ---
> v2: Alterations based on Ray Jui's review comments
> - shift setting of handler type inside spinlocked region
> - install handle_bad_irq as default handler for uninitialised interrupts

Patch applied. It just looks very good.

Yours,
Linus Walleij