On Thu, Dec 12, 2019 at 11:26 AM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > This is a part 3 of clean up pin control driver for Intel Baytrail. > After this applied the driver will use all available data structures > from pinctrl-intel.h header. > > Note, that patch which exposes common pin control data structrure for drivers > will be used by Lynxpoint as well. > > This has been tested on the tablet with SD card detection and buttons pressed. > > Based on our pinctrl/intel for-next branch. The series: Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Please collect up what you have and send this with a pull request so I have the full picture in my tree soon-ish. The reason is that I want a clean baseline to deal with this: $ git grep gpiochip_set_chained_irqchip drivers/pinctrl/ drivers/pinctrl/intel/pinctrl-baytrail.c: gpiochip_set_chained_irqchip(gc, &byt_irqchip, drivers/pinctrl/intel/pinctrl-cherryview.c: gpiochip_set_chained_irqchip(chip, &pctrl->irqchip, irq, drivers/pinctrl/intel/pinctrl-intel.c: gpiochip_set_chained_irqchip(&pctrl->chip, &pctrl->irqchip, irq, NULL); If you volunteer to get rid of these three gpiochip_set_chained_irqchip() calls, even better :D They are the three last users before I can delete gpiochip_set_chained_irqchip() from the kernel. Yours, Linus Walleij