Re: [PATCH] pinctrl: rza1: reduce printed messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chris,

On Wed, Dec 11, 2019 at 11:06:38AM -0500, Chris Brandt wrote:
> Since this message is printed for each port, it creates a lot of output
> during boot and would serve better only during debugging.
>
> Signed-off-by: Chris Brandt <chris.brandt@xxxxxxxxxxx>

Seems fair

> ---
>  drivers/pinctrl/pinctrl-rza1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-rza1.c b/drivers/pinctrl/pinctrl-rza1.c
> index 017fc6b3e27e..86e5bf59bde5 100644
> --- a/drivers/pinctrl/pinctrl-rza1.c
> +++ b/drivers/pinctrl/pinctrl-rza1.c
> @@ -1235,7 +1235,7 @@ static int rza1_parse_gpiochip(struct rza1_pinctrl *rza1_pctl,
>
>  	pinctrl_add_gpio_range(rza1_pctl->pctl, range);
>
> -	dev_info(rza1_pctl->dev, "Parsed gpiochip %s with %d pins\n",
> +	dev_dbg(rza1_pctl->dev, "Parsed gpiochip %s with %d pins\n",
>  		 chip->label, chip->ngpio);

Please align this line to the open ( ... Sorry to bother for such
minor thing.

There are other dev_info which might show up frequently, I'm
looking at line 1054 in example. I think it's fine as they show the
actually enabled groups...

Anway, minor alignement issue apart
Acked-by: Jacopo Mondi <jacopo@xxxxxxxxxx>

Thanks
   j
>
>  	return 0;
> --
> 2.23.0
>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux