Re: [PATCH] gpiolib: fix up emulated open drain outputs

[Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>]

niedz., 8 gru 2019 o 14:34 Kent Gibson <warthog618@xxxxxxxxx> napisał(a):
>
> > > > >
> > > > > What about the FLAG_OPEN_SOURCE case?
> > > >
> > > > do you have a scenario you can test?
> > > >
> > >
> > > No I don't - if I had a scenario that had tripped over this problem
> > > then I would've submitted a patch already ;-).
> > >
> > > I'm simply pointing out that the logic that applies to
> > > emulating OPEN_DRAIN also applies to emulating OPEN_SOURCE.
> > > IMHO if you are fixing this for one then it should be fixed for both.
> >
> > That would be nice, but it would also be nice to be sure that the fix
> > works there _and_ it doesn't break anything by fixing it.
> >
> > I regard this as a risky change: with open drain/open source "outputs"
> > it is quite obvious when the pin is being driven, it is in output mode.
> > When the driver is off though, it is debatable whether it should be
> > regarded as in input or output mode.
> >
>
> Higher powers can make the call on that.
>
> I just wanted to point out that the fix only deals with one of the two
> cases that need to be fixed - in case that slipped by.
>

I'll apply this patch as is and if someone reports problems with the
opposite condition, then we'll fix that too.

Bartosz