Re: [PATCH 1/5] gpio: export acpi_gpiochip_request_interrupts in gpio/driver.h

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Wed, Dec 4, 2019 at 3:39 PM Clément Leger <cleger@xxxxxxxxx> wrote:

> Ok, should I fix the original driver first and then submit the serie to add pinctrl ?

I guess so. Because we definitely don't want a churn with exporting
symbols like this.

> ----- On 4 Dec, 2019, at 13:35, Andy Shevchenko andy.shevchenko@xxxxxxxxx wrote:
> > On Wed, Dec 4, 2019 at 12:13 PM Clement Leger <cleger@xxxxxxxxx> wrote:
> >>
> >> dwapb-gpio driver which uses this function will be moved to pinctrl for
> >> pinctrl support. Export this function in gpio/driver.h to allow using
> >> it.

> > I don't think this is proper way to do it.
> > The driver has to register IRQ chip and GPIO core will take care of
> > ACPI related stuff.

-- 
With Best Regards,
Andy Shevchenko