Re: [PATCH] gpiolib: Fix error message on out-of-range GPIO in lookup table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 27, 2019 at 10:59 AM Geert Uytterhoeven
<geert+renesas@xxxxxxxxx> wrote:

> When a GPIO offset in a lookup table is out-of-range, the printed error
> message (1) does not include the actual out-of-range value, and (2)
> contains an off-by-one error in the upper bound.
>
> Avoid user confusion by also printing the actual GPIO offset, and
> correcting the upper bound of the range.
> While at it, use "%u" for unsigned int.
>
> Sample impact:
>
>     -requested GPIO 0 is out of range [0..32] for chip e6052000.gpio
>     +requested GPIO 0 (45) is out of range [0..31] for chip e6052000.gpio
>
> Fixes: 2a3cf6a3599e9015 ("gpiolib: return -ENOENT if no GPIO mapping exists")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Patch applied for fixes!

Thanks!
Linus Walleij



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux