Hi Geert, Am 27.11.19 um 21:37 schrieb Geert Uytterhoeven: > On Wed, Nov 27, 2019 at 5:46 PM Nishad Kamdar <nishadkamdar@xxxxxxxxx> wrote: >> This patch corrects the SPDX License Identifier style in >> header files related to Reneses Soc pinctrl driver. >> It assigns explicit block comment for the SPDX License Identifier. > > Is it incorrect to not have an explicit block comment? Yes, Greg said so to me. He suggested I provide a patch against the documentation if the docs are not clear enough, but I didn't get around to it (and it's not my rule in the first place, so I'd appreciate the person making that rule to take care of documenting it). However, if we're touching these lines anyway, shouldn't we be updating the SPDX Identifier to GPL-2.0-only while at it? Cheers, Andreas -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg)