Re: [PATCH v2 2/3] mfd: da9062: add support for the DA9062 GPIOs in the core

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Wed, Nov 27, 2019 at 12:56 PM Marco Felsch <m.felsch@xxxxxxxxxxxxxx> wrote:

> Currently the da9062 GPIO's aren't available. The patch adds the support
> to make these available by adding a gpio device with the corresponding
> irq resources. Furthermore the patch fixes a minor style issue for the
> onkey device.
>
> Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>

This is a regmap irqchip so I guess not much to say about it.
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

HOWEVER: this looks very much hierarchical does it not?

I can clearly see that regmap's irqchip does not support
hierarchical interrupt domains, so we should just make a
mental note somewhere that "oh yeah and then one day
we should make regmap irqchips play well with hierarchical
interrupts".

Yours,
Linus Walleij