RE: [PATCH v2 1/5] genirq: introduce irq_domain_translate_onecell

[Yash Shah <yash.shah@xxxxxxxxxx>]

> -----Original Message-----
> From: Marc Zyngier <maz@xxxxxxxxxx>
> Sent: 20 November 2019 16:09
> To: Yash Shah <yash.shah@xxxxxxxxxx>
> Cc: linus.walleij@xxxxxxxxxx; bgolaszewski@xxxxxxxxxxxx;
> robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; palmer@xxxxxxxxxxx; Paul
> Walmsley ( Sifive) <paul.walmsley@xxxxxxxxxx>; aou@xxxxxxxxxxxxxxxxx;
> tglx@xxxxxxxxxxxxx; jason@xxxxxxxxxxxxxx; bmeng.cn@xxxxxxxxx;
> atish.patra@xxxxxxx; Sagar Kadam <sagar.kadam@xxxxxxxxxx>; linux-
> gpio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> riscv@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Sachin Ghadi
> <sachin.ghadi@xxxxxxxxxx>
> Subject: Re: [PATCH v2 1/5] genirq: introduce irq_domain_translate_onecell
> 
> On 2019-11-20 06:59, Yash Shah wrote:
> > Add a new function irq_domain_translate_onecell() that is to be used
> > as the translate function in struct irq_domain_ops for the v2 IRQ API.
> >
> > Signed-off-by: Yash Shah <yash.shah@xxxxxxxxxx>
[...]
> >
> >  /**
> > + * irq_domain_translate_onecell() - Generic translate for direct one
> > cell
> > + * bindings
> > + *
> > + * Device Tree IRQ specifier translation function which works with
> > one cell
> 
> nit: the whole point of the 'new' translate function is that they are
> firmware-agnostic. Just drop the DT reference here.

Ok sure.

> 
> > + * bindings where the cell values map directly to the hwirq number.
> > + */
> > +int irq_domain_translate_onecell(struct irq_domain *d,
> > +				 struct irq_fwspec *fwspec,
> > +				 unsigned long *out_hwirq,
> > +				 unsigned int *out_type)
> > +{
> > +	if (WARN_ON(fwspec->param_count < 1))
> > +		return -EINVAL;
> > +	*out_hwirq = fwspec->param[0];
> > +	*out_type = IRQ_TYPE_NONE;
> > +	return 0;
> > +}
> > +EXPORT_SYMBOL_GPL(irq_domain_translate_onecell);
> > +
> > +/**
> >   * irq_domain_translate_twocell() - Generic translate for direct two
> > cell
> >   * bindings
> >   *
> 
> Can you please also update (potentially in a separate patch) the
> potential
> users of this? I mentioned the nvic driver last time...
> 

Ok, I will separate out this patch from the patchset and send it individually along with potential users of it.
Thanks for your comments

- Yash