Re: [libgpiod] [PATCH 02/19] API: add support for bias flags

[Kent Gibson <warthog618@xxxxxxxxx>]

On Mon, Nov 18, 2019 at 02:51:06PM +0100, Bartosz Golaszewski wrote:
> pt., 15 lis 2019 o 15:44 Kent Gibson <warthog618@xxxxxxxxx> napisał(a):
> >
> > Extend the libgpiod API to support the bias flags recently added to the
> > kernel GPIO uAPI.  The core change is the addition of
> > GPIOD_LINE_REQUEST_FLAG_BIAS_DISABLE, GPIOD_LINE_REQUEST_FLAG_BIAS_PULL_UP
> > and GPIOD_LINE_REQUEST_FLAG_BIAS_PULL_DOWN flags to be passed into
> > line_request functions, and the addition of gpiod_line_bias to return the
> > bias state of lines.
> >
> > Extended variants of the ctxless functions that accept an active_low flag
> > are added to also accept other flags. The variant names add a "_ext"
> > suffix to the name of the original function.
> >
> > Based on initial work by Drew Fustini <drew@xxxxxxxx>.
> >
> > Signed-off-by: Kent Gibson <warthog618@xxxxxxxxx>
> 
> Hi Kent,
> 
> this looks good, just a couple nits. I'd change the subject line to
> "core: add support for bias flags". Also: how about moving the flags
> argument to the last position in all the ctxless extended variants, so
> that they keep the same signature *except* for the appended new
> argument?
> 

Will do.

Kent.