On Mon, Nov 11, 2019 at 11:11 AM Rahul Tanwar <rahul.tanwar@xxxxxxxxxxxxxxx> wrote: > Add dt bindings document for pinmux & GPIO controller driver of > Intel Lightning Mountain SoC. > > Signed-off-by: Rahul Tanwar <rahul.tanwar@xxxxxxxxxxxxxxx> (...) > +properties: > + compatible: > + const: intel,lgm-pinctrl Just noted from another review where Rob noted that this name should match the internal name in the datasheet for this hardware block. Is it really called "lgm-pinctrl" inside Intel? intel,lightning-mountain-io and similar are perfectly fine if that is the name it has in your documentation. Yours, Linus Walleij