On Thu, Nov 07, 2019 at 12:28:09PM +0100, Bartosz Golaszewski wrote: > czw., 7 lis 2019 o 11:39 Kent Gibson <warthog618@xxxxxxxxx> napisał(a): > > > > On Thu, Nov 07, 2019 at 12:58:04AM +0800, Kent Gibson wrote: > > > I've pushed some more changes with the updated API we discussed earlier. > > > Those new tests I'd added now pass. Yay. > > > One problem though - gpiod_line_set_config as written has no way to > > > accept an as-is direction. > > > Hopefully I'll have some time to take another look at that tomorrow. > > > > > > > I've pushed some more updates to my libgpiod branch[1]. They fix the > > direction limitation I mentioned (I was using the wrong set flags), > > and extend the tests to cover all of the SET_CONFIG fields. > > > > That completes the C API changes. > > If that is ok with you then I can take a look at the corresponding > > changes to the C++ and Python bindings. > > > > And I guess we should move this libgpiod discussion to a new thread? > > Yes, and better yet - you could simply send these patches for review > and we can continue the discussion there. > I was holding off on putting a patch series together until all the functionality was complete - so after the C++ and Python bindings. Cheers, Kent.