Re: [RESEND][PATCH v2 0/7] gpiolib: fix GPIO <-> pin mapping registration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 05, 2019 at 10:35:50PM +0200, Andy Shevchenko wrote:
> This is the ordering fix for GPIO <-> pin mapping registration to allow
> delegation of IRQ chip to the GPIO library. Two drivers are actually converted
> to use the new callback followed by switching to use of irqchip structure
> inside gpiochip.
> 
> The series has been tested on Merrifield device (though no AEI) and on Thinkpad
> 10 where 4 events are registered, one of which has reasonable amount of
> interrupts coming from battery.
> 
> First two patches are definitely good for v5.4 cycle (and have Fixes tag) while
> the rest can be applied for v5.5 if I didn't miss anything. So, they can go like
> patches 1-3 -> v5.4 (gpio/fixes) and to gpio/for-next and to pinctrl/for-next
> patches 4-5 -> v5.5 (gpio/for-next)
> patches 6-7 -> v5.5 (pinctrl/for-next)
> 
> Perhaps it would require to wait next v5.4 rc in order to avoid dependency
> issues.

So, I consolidated everything I have under my review-andy branch in
pinctrl/intel.git repository.

When I applied Hans' CHV series, I fixed minor conflict due to new small patch
in for-next branch.

Linus, I think it would be good if we have first 3 (okay, I noticed you have
pushed first one to your devel branch) patches to go to v5.4. It will reduce
dependency burden in v5.5.

Hans, if you have time you can test altogether (actually that set I used for
local testing, so, I'm not expecting anything unusual there).

> Changelog v2 (resent):
> - fixed cover letter
> - resent with ML included
> 
> Changelog v2:
> - added fixes tag to the first patch
> - reworked commit message for the second patch
> - added baytrail conversion
> - tested on ThinkPad 10
> 
> Andy Shevchenko (6):
>   gpiolib: No need to call gpiochip_remove_pin_ranges() twice
>   gpiolib: Introduce ->add_pin_ranges() callback
>   gpio: merrifield: Add GPIO <-> pin mapping ranges via callback
>   gpio: merrifield: Pass irqchip when adding gpiochip
>   pinctrl: baytrail: Add GPIO <-> pin mapping ranges via callback
>   pinctrl: baytrail: Pass irqchip when adding gpiochip
> 
> Linus Walleij (1):
>   gpiolib: Switch order of valid mask and hw init
> 
>  drivers/gpio/gpio-merrifield.c           | 76 ++++++++++++++----------
>  drivers/gpio/gpiolib-of.c                |  5 +-
>  drivers/gpio/gpiolib.c                   | 19 +++++-
>  drivers/pinctrl/intel/pinctrl-baytrail.c | 64 ++++++++++++--------
>  include/linux/gpio/driver.h              |  5 ++
>  5 files changed, 107 insertions(+), 62 deletions(-)
> 
> -- 
> 2.24.0.rc1
> 

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux