Re: [PATCH 1/3] pinctrl: cherryview: Split out irq hw-init into a separate helper function

[Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>]

On Wed, Nov 06, 2019 at 01:09:54PM +0100, Hans de Goede wrote:
> Split out irq hw-init into a separate chv_gpio_irq_init_hw() function.
> This is a preparation patch for passing the irqchip when adding the
> gpiochip.
> 
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
>  drivers/pinctrl/intel/pinctrl-cherryview.c | 57 +++++++++++++---------
>  1 file changed, 34 insertions(+), 23 deletions(-)
> 
> diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
> index dff2a81250b6..c5a44be1e904 100644
> --- a/drivers/pinctrl/intel/pinctrl-cherryview.c
> +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
> @@ -165,6 +165,7 @@ struct chv_pinctrl {
>  	struct gpio_chip chip;
>  	struct irq_chip irqchip;
>  	void __iomem *regs;
> +	bool need_valid_mask;

Please add kernel-doc about this one.

Otherwise looks good.