Re: [PATCH v2 7/7] pinctrl: baytrail: Pass irqchip when adding gpiochip

[Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>]

On Tue, Nov 05, 2019 at 10:35:57PM +0200, Andy Shevchenko wrote:
> We need to convert all old gpio irqchips to pass the irqchip
> setup along when adding the gpio_chip. For more info see
> drivers/gpio/TODO.
> 
> For chained irqchips this is a pretty straight-forward conversion.
> 
> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> Cc: Thierry Reding <treding@xxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  drivers/pinctrl/intel/pinctrl-baytrail.c | 43 ++++++++++++++----------
>  1 file changed, 25 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
> index b4d0e945e8c2..1234fe5f2a27 100644
> --- a/drivers/pinctrl/intel/pinctrl-baytrail.c
> +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
> @@ -1450,9 +1450,9 @@ static void byt_init_irq_valid_mask(struct gpio_chip *chip,
>  	 */
>  }
>  
> -static void byt_gpio_irq_init_hw(struct byt_gpio *vg)
> +static int byt_gpio_irq_init_hw(struct gpio_chip *chip)
>  {
> -	struct gpio_chip *gc = &vg->chip;
> +	struct byt_gpio *vg = gpiochip_get_data(chip);
>  	struct device *dev = &vg->pdev->dev;
>  	void __iomem *reg;
>  	u32 base, value;
> @@ -1476,7 +1476,7 @@ static void byt_gpio_irq_init_hw(struct byt_gpio *vg)
>  
>  		value = readl(reg);
>  		if (value & BYT_DIRECT_IRQ_EN) {
> -			clear_bit(i, gc->irq.valid_mask);
> +			clear_bit(i, chip->irq.valid_mask);
>  			dev_dbg(dev, "excluding GPIO %d from IRQ domain\n", i);
>  		} else if ((value & BYT_PIN_MUX) == byt_get_gpio_mux(vg, i)) {
>  			byt_gpio_clear_triggering(vg, i);
> @@ -1504,6 +1504,8 @@ static void byt_gpio_irq_init_hw(struct byt_gpio *vg)
>  				"GPIO interrupt error, pins misconfigured. INT_STAT%u: 0x%08x\n",
>  				base / 32, value);
>  	}
> +
> +	return 0;
>  }
>  
>  static int byt_gpio_add_pin_ranges(struct gpio_chip *chip)
> @@ -1542,26 +1544,31 @@ static int byt_gpio_probe(struct byt_gpio *vg)
>  	if (!vg->saved_context)
>  		return -ENOMEM;
>  #endif
> -	ret = devm_gpiochip_add_data(&vg->pdev->dev, gc, vg);
> -	if (ret) {
> -		dev_err(&vg->pdev->dev, "failed adding byt-gpio chip\n");
> -		return ret;
> -	}
>  
>  	/* set up interrupts  */
>  	irq_rc = platform_get_resource(vg->pdev, IORESOURCE_IRQ, 0);
>  	if (irq_rc && irq_rc->start) {
> -		byt_gpio_irq_init_hw(vg);
> -		ret = gpiochip_irqchip_add(gc, &byt_irqchip, 0,
> -					   handle_bad_irq, IRQ_TYPE_NONE);
> -		if (ret) {
> -			dev_err(&vg->pdev->dev, "failed to add irqchip\n");
> -			return ret;
> -		}
> +		struct gpio_irq_chip *girq;
> +
> +		girq = &gc->irq;
> +		girq->chip = &byt_irqchip;
> +		girq->init_hw = byt_gpio_irq_init_hw;
> +		girq->parent_handler = byt_gpio_irq_handler;
> +		girq->num_parents = 1;
> +		girq->parents = devm_kcalloc(&vg->pdev->dev, 1,
> +					     sizeof(*girq->parents),
> +					     GFP_KERNEL);

Here also

		girq->parents = devm_kcalloc(&vg->pdev->dev, 1,
					     sizeof(*girq->parents), GFP_KERNEL);


Regardless of that,

Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>