Re: [PATCH v3 2/2] pinctrl: bcm: nsp: implement get_direction

[Chris Packham <Chris.Packham@xxxxxxxxxxxxxxxxxxx>]

On Mon, 2019-11-04 at 16:24 +0100, Linus Walleij wrote:
> On Mon, Nov 4, 2019 at 1:18 AM Chris Packham
> <chris.packham@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > The get_direction api is strongly recommended to be implemented. In fact
> > if it is not implemented gpio-hogs will not get the correct direction.
> > Add an implementation of get_direction for the nsp-gpio driver.
> > 
> > Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
> > Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> 
> BTW I think it looks like this the GPIO part of this driver can be
> converted to use GPIO_GENERIC. Compare to other
> drivers such as drivers/gpio/gpio-ftgpio010.c.
> 
> It's a fun way to cut down lines if you have time to check
> and test!
> 

I'll see if I can fit it in. Got another problem I'm chasing on the
same platform.