On Thu, Oct 10, 2019 at 09:52:09PM +0800, zhengbin wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpio/gpio-merrifield.c: In function mrfld_gpio_probe: > drivers/gpio/gpio-merrifield.c:402:17: warning: variable irq_base set but not used [-Wunused-but-set-variable] > It is not used since commit 8f86a5b4ad67 ("gpio: merrifield: > Pass irqchip when adding gpiochip") ...which is wrong. Please, see this [1] thread for the details. NAK. [1]: https://lore.kernel.org/linux-gpio/20191009165056.76580-1-andriy.shevchenko@xxxxxxxxxxxxxxx/T/#t -- With Best Regards, Andy Shevchenko