Re: [PATCH 2/2] tracing: drop handling of NOTRACE symbol

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Fri, Sep 27, 2019 at 2:41 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:

> I put it in a separate branch and push to the build servers so
> we can see if something happens!

Oh there it is... buildserver says:

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git
 devel-drop-trace
branch HEAD: 40da9a24a778d94e034d160bfacf4931ae5922cd  tracing: drop
handling of NOTRACE symbol

Regressions in current branch:

kernel/trace/trace_events_filter.c:2105:14: error: field name not in
record or union initializer
kernel/trace/trace_events_filter.c:2115:44: error: field 'rec' has
incomplete type
kernel/trace/trace_events_filter.c:2121:2: note: in expansion of macro
'DATA_REC'
kernel/trace/trace_events_filter.c:2142:9: sparse: sparse: too many errors
kernel/trace/trace_events_filter.c:2222:29: error: passing argument 2
of 'create_filter' from incompatible pointer type
[-Werror=incompatible-pointer-types]
kernel/trace/trace_events_filter.c:2222:30: error:
'event_ftrace_test_filter' undeclared (first use in this function);
did you mean 'trace_ftrace_test_filter'?

Error ids grouped by kconfigs:

recent_errors
|-- arm-allmodconfig
|   |-- kernel-trace-trace_events_filter.c:error:event_ftrace_test_filter-undeclared-(first-use-in-this-function)-did-you-mean-trace_ftrace_test_filter
|   |-- kernel-trace-trace_events_filter.c:error:field-name-not-in-record-or-union-initializer
|   |-- kernel-trace-trace_events_filter.c:error:field-rec-has-incomplete-type
|   |-- kernel-trace-trace_events_filter.c:error:passing-argument-of-create_filter-from-incompatible-pointer-type
|   `-- kernel-trace-trace_events_filter.c:note:in-expansion-of-macro-DATA_REC
|-- arm64-allmodconfig
|   |-- kernel-trace-trace_events_filter.c:error:event_ftrace_test_filter-undeclared-(first-use-in-this-function)-did-you-mean-trace_ftrace_test_filter
|   |-- kernel-trace-trace_events_filter.c:error:field-name-not-in-record-or-union-initializer
|   |-- kernel-trace-trace_events_filter.c:error:field-rec-has-incomplete-type
|   |-- kernel-trace-trace_events_filter.c:error:passing-argument-of-create_filter-from-incompatible-pointer-type
|   `-- kernel-trace-trace_events_filter.c:note:in-expansion-of-macro-DATA_REC
|-- arm64-allyesconfig
|   |-- kernel-trace-trace_events_filter.c:error:event_ftrace_test_filter-undeclared-(first-use-in-this-function)-did-you-mean-trace_ftrace_test_filter
|   |-- kernel-trace-trace_events_filter.c:error:field-name-not-in-record-or-union-initializer
|   |-- kernel-trace-trace_events_filter.c:error:field-rec-has-incomplete-type
|   |-- kernel-trace-trace_events_filter.c:error:passing-argument-of-create_filter-from-incompatible-pointer-type
|   `-- kernel-trace-trace_events_filter.c:note:in-expansion-of-macro-DATA_REC
|-- mips-allmodconfig
|   |-- kernel-trace-trace_events_filter.c:error:event_ftrace_test_filter-undeclared-(first-use-in-this-function)-did-you-mean-trace_ftrace_test_filter
|   |-- kernel-trace-trace_events_filter.c:error:field-name-not-in-record-or-union-initializer
|   |-- kernel-trace-trace_events_filter.c:error:field-rec-has-incomplete-type
|   |-- kernel-trace-trace_events_filter.c:error:passing-argument-of-create_filter-from-incompatible-pointer-type
|   `-- kernel-trace-trace_events_filter.c:note:in-expansion-of-macro-DATA_REC
|-- s390-allmodconfig
|   |-- kernel-trace-trace_events_filter.c:error:event_ftrace_test_filter-undeclared-(first-use-in-this-function)-did-you-mean-trace_ftrace_test_filter
|   |-- kernel-trace-trace_events_filter.c:error:field-name-not-in-record-or-union-initializer
|   |-- kernel-trace-trace_events_filter.c:error:field-rec-has-incomplete-type
|   |-- kernel-trace-trace_events_filter.c:error:passing-argument-of-create_filter-from-incompatible-pointer-type
|   `-- kernel-trace-trace_events_filter.c:note:in-expansion-of-macro-DATA_REC
|-- sh-allmodconfig
|   |-- kernel-trace-trace_events_filter.c:error:event_ftrace_test_filter-undeclared-(first-use-in-this-function)-did-you-mean-trace_ftrace_test_filter
|   |-- kernel-trace-trace_events_filter.c:error:field-name-not-in-record-or-union-initializer
|   |-- kernel-trace-trace_events_filter.c:error:field-rec-has-incomplete-type
|   |-- kernel-trace-trace_events_filter.c:error:passing-argument-of-create_filter-from-incompatible-pointer-type
|   `-- kernel-trace-trace_events_filter.c:note:in-expansion-of-macro-DATA_REC
|-- sparc64-allmodconfig
|   |-- kernel-trace-trace_events_filter.c:error:event_ftrace_test_filter-undeclared-(first-use-in-this-function)-did-you-mean-trace_ftrace_test_filter
|   |-- kernel-trace-trace_events_filter.c:error:field-name-not-in-record-or-union-initializer
|   |-- kernel-trace-trace_events_filter.c:error:field-rec-has-incomplete-type
|   |-- kernel-trace-trace_events_filter.c:error:passing-argument-of-create_filter-from-incompatible-pointer-type
|   `-- kernel-trace-trace_events_filter.c:note:in-expansion-of-macro-DATA_REC
|-- x86_64-allmodconfig
|   |-- kernel-trace-trace_events_filter.c:error:event_ftrace_test_filter-undeclared-(first-use-in-this-function)-did-you-mean-trace_ftrace_test_filter
|   |-- kernel-trace-trace_events_filter.c:error:field-name-not-in-record-or-union-initializer
|   |-- kernel-trace-trace_events_filter.c:error:field-rec-has-incomplete-type
|   |-- kernel-trace-trace_events_filter.c:error:passing-argument-of-create_filter-from-incompatible-pointer-type
|   |-- kernel-trace-trace_events_filter.c:note:in-expansion-of-macro-DATA_REC
|   `-- kernel-trace-trace_events_filter.c:sparse:sparse:too-many-errors
`-- x86_64-allyesconfig
    |-- kernel-trace-trace_events_filter.c:error:event_ftrace_test_filter-undeclared-(first-use-in-this-function)-did-you-mean-trace_ftrace_test_filter
    |-- kernel-trace-trace_events_filter.c:error:field-name-not-in-record-or-union-initializer
    |-- kernel-trace-trace_events_filter.c:error:field-rec-has-incomplete-type
    |-- kernel-trace-trace_events_filter.c:error:passing-argument-of-create_filter-from-incompatible-pointer-type
    `-- kernel-trace-trace_events_filter.c:note:in-expansion-of-macro-DATA_REC

I looked into this last time but couldn't wrap my head around it.

Yours,
Linus Walleij