Re: [PATCH 1/4] gpio/aspeed: Fix incorrect number of banks

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Wed, Sep 4, 2019 at 9:14 AM Rashmica Gupta <rashmica.g@xxxxxxxxx> wrote:
>
> Fixes: 361b79119a4b7 ('gpio: Add Aspeed driver')
>
> Signed-off-by: Rashmica Gupta <rashmica.g@xxxxxxxxx>

>         /* Allocate a cache of the output registers */
> -       banks = gpio->config->nr_gpios >> 5;
> +       banks = (gpio->config->nr_gpios >> 5) + 1;

Shouldn't be rather DIV_ROUND_UP(nr_gpios, sizeof(u32)) ?

>         gpio->dcache = devm_kcalloc(&pdev->dev,
>                                     banks, sizeof(u32), GFP_KERNEL);


-- 
With Best Regards,
Andy Shevchenko