Re: [PATCH] gpio: mockup: add missing single_release()

[Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>]

śr., 4 wrz 2019 o 16:00 Wei Yongjun <weiyongjun1@xxxxxxxxxx> napisał(a):
>
> When using single_open() for opening, single_release() should be
> used instead of seq_release(), otherwise there is a memory leak.
>
> Fixes: 2a9e27408e12 ("gpio: mockup: rework debugfs interface")
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> ---
>  drivers/gpio/gpio-mockup.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
> index f1a9c0544e3f..213aedc97dc2 100644
> --- a/drivers/gpio/gpio-mockup.c
> +++ b/drivers/gpio/gpio-mockup.c
> @@ -309,6 +309,7 @@ static const struct file_operations gpio_mockup_debugfs_ops = {
>         .read = gpio_mockup_debugfs_read,
>         .write = gpio_mockup_debugfs_write,
>         .llseek = no_llseek,
> +       .release = single_release,
>  };
>
>  static void gpio_mockup_debugfs_setup(struct device *dev,
>
>
>

Good catch!

Reviewed-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>

Linus: can you pick it up for your last pull-requests with fixes for v5.3?

Bart