Re: [PATCH] pinctrl: bcm2835: Pass irqchip when adding gpiochip

[Stefan Wahren <stefan.wahren@xxxxxxxx>]

Hi Linus,

Am 23.08.19 um 10:07 schrieb Stefan Wahren:
> Hi Linus,
>
> [removed Simon from CC to stop annoy him]
>
> On 23.08.19 09:46, Linus Walleij wrote:
>> On Mon, Aug 12, 2019 at 8:29 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>>
>>> We need to convert all old gpio irqchips to pass the irqchip
>>> setup along when adding the gpio_chip. For more info see
>>> drivers/gpio/TODO.
>>>
>>> For chained irqchips this is a pretty straight-forward
>>> conversion. The BCM2835 has multiple parents so let's
>>> exploit the new facility in the GPIO_IRQCHIP to actually
>>> deal with multiple parents.
>>>
>>> Cc: Simon Arlott <simon@xxxxxxxxxx>
please remove Simon's email address before applying
>>> Cc: Eric Anholt <eric@xxxxxxxxxx>
>>> Cc: Stefan Wahren <stefan.wahren@xxxxxxxx>
and use my new address in the future.
>>> Cc: Thierry Reding <treding@xxxxxxxxxx>
>>> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>> This patch is a bit scary because I haven't tried converting multiple
>> parents before. Any chance one of you RPi people could give it
>> a test run, so you don't have to experience testing it in linux-next?
> it's on my TODO list, but i didn't had the time to test it yet.
>
> Can you give me some test ideas?

I configured a GPIO as input with pull-up, setup the interrupt via sysfs
and wired the GPIO to GND.
After that i checked that /proc/interrupts for the pin has increased.
Everything worked as expected.

Is it sufficient?

Tested-by: Stefan Wahren <stefan.wahren@xxxxxxxx>

>
>> Yours,
>> Linus Walleij