Re: [PATCH v2] microblaze: Switch to standard restart handler

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Fri, Aug 23, 2019 at 12:56 PM Michal Simek <monstr@xxxxxxxxx> wrote:

> > +void machine_restart(char *cmd)
> > +{
> > +     do_kernel_restart(cmd);
> > +     /* Give the restart hook 1 s to take us down */
> > +     mdelay(1000);
> > +     pr_emerg("Reboot failed -- System halted\n");
> > +     while (1);
> > +}
> > +
> >  /*
> >   * MMU_init sets up the basic memory mappings for the kernel,
> >   * including both RAM and possibly some I/O regions,
> >
>
> I will test this for sure. What's the reason to add machine_restart to
> mm/ folder? You can simply keep it in a location where it was.

It is because the three calls to machine_restart() were in this
file and therefore I just put it in proximity.

I can move it.

> Do you know why of_find_gpio can failed in connection to gpio-xilinx driver?

The only reason it'd fail would be if the module is not compiled
in, or deferred probe happens, but then -EPROBE_DEFER
would be returned I think.

Yours,
Linus Walleij