Hi Greg, On Wed, Aug 21, 2019 at 2:22 PM Greg Ungerer <gerg@xxxxxxxxxxxxxx> wrote: > On 21/8/19 5:19 pm, Geert Uytterhoeven wrote: > > CC Greg (coldfire) > > Thanks Geert. > I am happy to take it via the m68knommu tree if you prefer? Sounds most logical to me. Thanks! > > On Wed, Aug 21, 2019 at 9:09 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > >> The Coldfire GPIO driver needs to explicitly incldue the > >> GPIO driver header since it is providing a driver. > >> > >> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > >> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > >> --- > >> Geert can you pick this up for m68k? > >> --- > >> arch/m68k/coldfire/gpio.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/arch/m68k/coldfire/gpio.c b/arch/m68k/coldfire/gpio.c > >> index a83898426127..ca26de257871 100644 > >> --- a/arch/m68k/coldfire/gpio.c > >> +++ b/arch/m68k/coldfire/gpio.c > >> @@ -9,6 +9,7 @@ > >> #include <linux/module.h> > >> #include <linux/init.h> > >> #include <linux/device.h> > >> +#include <linux/gpio/driver.h> > >> > >> #include <linux/io.h> > >> #include <asm/coldfire.h> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds