In pinctrl-spmi-gpio.c there is a switch case which is obviously intended to fall through to the next label. Add a comment to suppress -Wimplicit-fallthrough warning. Signed-off-by: Alex Dewar <alex.dewar@xxxxxxxxx> --- drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c index f39da87ea185..b035dd5e25b8 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c @@ -813,6 +813,7 @@ static int pmic_gpio_populate(struct pmic_gpio_state *state, switch (subtype) { case PMIC_GPIO_SUBTYPE_GPIO_4CH: pad->have_buffer = true; + /* FALLS THROUGH */ case PMIC_GPIO_SUBTYPE_GPIOC_4CH: pad->num_sources = 4; break; -- 2.22.1