Re: [PATCH] gpio: aspeed: Pass irqchip when adding gpiochip

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Tue, Aug 13, 2019 at 6:44 AM Joel Stanley <joel@xxxxxxxxx> wrote:
> On Fri, 9 Aug 2019 at 12:55, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:

> > +               girq->parents = devm_kcalloc(&pdev->dev, 1,
> > +                                            sizeof(*girq->parents),
> > +                                            GFP_KERNEL);
>
> Is there a reason this is kcalloc and not kzalloc?

Following the pattern that we have one item of sizeof().
The parents can be several, so we try to follow this
pattern so people get it right.

> Acked-by: Joel Stanley <joel@xxxxxxxxx>

Thanks!

Yours,
Linus Walleij