On Thu, 15 Aug 2019 at 08:09, Nishka Dasgupta <nishkadg.linux@xxxxxxxxx> wrote: > > Each iteration of for_each_child_of_node puts the previous node, but in > the case of a return from the middle of the loop, there is no put, thus > causing a memory leak. Hence add an of_node_put before the return in > three places. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta <nishkadg.linux@xxxxxxxxx> > --- > drivers/pinctrl/samsung/pinctrl-samsung.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) This is already fixed. You can base your patches on top of linux-next to avoid duplicating effort. Best regards, Krzysztof