Re: [PATCH v2] pinctrl: intel: Allow to request locked pads

[Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>]

On Thu, Aug 08, 2019 at 04:21:28PM +0300, Andy Shevchenko wrote:
> Some firmwares would like to protect pads from being modified by OS
> and at the same time provide them to OS as a resource. So, the driver
> in such circumstances may request pad and may not change its state.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> in v2:
> - amended comment in intel_pad_locked() respectively to the change (Mika)
> - described enum values (Linus)
> - lowered case for locking flavour in debugfs for better looking
>  drivers/pinctrl/intel/pinctrl-intel.c | 67 ++++++++++++++++++++-------
>  1 file changed, 50 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
> index c949df07cbdf..b84a5579beee 100644
> --- a/drivers/pinctrl/intel/pinctrl-intel.c
> +++ b/drivers/pinctrl/intel/pinctrl-intel.c
> @@ -220,47 +220,69 @@ static bool intel_pad_acpi_mode(struct intel_pinctrl *pctrl, unsigned int pin)
>  	return !(readl(hostown) & BIT(gpp_offset));
>  }
>  
> -static bool intel_pad_locked(struct intel_pinctrl *pctrl, unsigned int pin)
> +/*

This should be /**

> + * PAD_UNLOCKED:	pad is fully controlled by the configuration registers

These should have @ prefix, I think.

Otherwise looks good.