Re: [PATCH 1/4 v1] gpio: Add support for hierarchical IRQ domains

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

Hi Masahiro,

On Thu, Jul 18, 2019 at 1:12 PM Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:
> On Mon, Jun 24, 2019 at 10:25 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:

> > +static int gpiochip_hierarchy_irq_domain_alloc(struct irq_domain *d,
> > +                                              unsigned int irq,
> > +                                              unsigned int nr_irqs,
> > +                                              void *data)
> > +{
> > +       struct gpio_chip *gc = d->host_data;
> > +       irq_hw_number_t hwirq;
> > +       unsigned int type = IRQ_TYPE_NONE;
> > +       struct irq_fwspec *fwspec = data;
> > +       int ret;
> > +       int i;
>
> We always expect nr_irqs is 1.
>
> As gpio-uniphier.c, you can error out with WARN_ON
> if nr_irqs != 1

Hm, yes I am pretty sure it is always 1.

But I'd like to defer changing this until/if Marc changes
the signature of the function to not pass nr_irqs anymore.
I try to design for the current prototype because I don't
know how e.g. ACPI works with respect to this.

> I see so many chip_info().
> I think they should be chip_dbg() or removed entirely.

I am keeping that right now as we're testing on several
different systems, so some extra debug prints should be
OK in a transitional period. We might change it into dbg
with a separate patch before the merge window.

The rest of your comments are addressed!

Yours,
Linus Walleij